mirror of
https://github.com/laravel/valet.git
synced 2026-02-04 16:10:08 +01:00
7ef4bac510
When running PHP with extensions like imagick, sometimes the extension needs a rebuild after `brew upgrade`. Otherwise, it will throw a warning: ``` Warning: Version warning: Imagick was compiled against ImageMagick version 1809 but version 1810 is loaded. Imagick will run but may behave surprisingly in Unknown on line 0 ``` This warning is also printed, within the shell executions in Valet. But we use the output of those PHP CLI invocations. With those warnings being printed out, the parsing on the output fails and Valet cannot be used until the pecl extension is rebuilt. With this patch, all CLI PHP invocations use ` -d error_reporting=1`. This suppresses warnings, but will still report errors. It makes valet more robust in case a system package update causes warnings.
92 lines
2.8 KiB
PHP
92 lines
2.8 KiB
PHP
<?php
|
|
|
|
$minimumPhpVersion = '8.0';
|
|
|
|
// First, check if the system's linked "php" is 8+; if so, return that. This
|
|
// is the most likely, most ideal, and fastest possible case
|
|
$linkedPhpVersion = shell_exec('php -d error_reporting=1 -r "echo phpversion();"');
|
|
|
|
if (version_compare($linkedPhpVersion, $minimumPhpVersion) >= 0) {
|
|
echo exec('which php');
|
|
|
|
return;
|
|
}
|
|
|
|
// If not, let's find it whether we have a version of PHP installed that's 8+;
|
|
// all users that run through this code path will see Valet run more slowly
|
|
$phps = explode(PHP_EOL, trim(shell_exec('brew list --formula | grep php')));
|
|
|
|
// Normalize version numbers
|
|
$phps = array_reduce($phps, function ($carry, $php) {
|
|
$carry[$php] = presumePhpVersionFromBrewFormulaName($php);
|
|
|
|
return $carry;
|
|
}, []);
|
|
|
|
// Filter out older versions of PHP
|
|
$modernPhps = array_filter($phps, function ($php) use ($minimumPhpVersion) {
|
|
return version_compare($php, $minimumPhpVersion) >= 0;
|
|
});
|
|
|
|
// If we don't have any modern versions of PHP, throw an error
|
|
if (empty($modernPhps)) {
|
|
throw new Exception('Sorry, but you do not have a version of PHP installed that is compatible with Valet (8+).');
|
|
}
|
|
|
|
// Sort newest version to oldest
|
|
sort($modernPhps);
|
|
$modernPhps = array_reverse($modernPhps);
|
|
|
|
// Grab the highest, set as $foundVersion, and output its path
|
|
$foundVersion = reset($modernPhps);
|
|
echo getPhpExecutablePath(array_search($foundVersion, $phps));
|
|
|
|
/**
|
|
* Function definitions.
|
|
*/
|
|
|
|
/**
|
|
* Extract PHP executable path from PHP Version.
|
|
* Copied from Brew.php and modified.
|
|
*
|
|
* @param string|null $phpFormulaName For example, "php@8.1"
|
|
* @return string
|
|
*/
|
|
function getPhpExecutablePath(?string $phpFormulaName = null)
|
|
{
|
|
$brewPrefix = exec('printf $(brew --prefix)');
|
|
|
|
// Check the default `/opt/homebrew/opt/php@8.1/bin/php` location first
|
|
if (file_exists($brewPrefix."/opt/{$phpFormulaName}/bin/php")) {
|
|
return $brewPrefix."/opt/{$phpFormulaName}/bin/php";
|
|
}
|
|
|
|
// Check the `/opt/homebrew/opt/php71/bin/php` location for older installations
|
|
$oldPhpFormulaName = str_replace(['@', '.'], '', $phpFormulaName); // php@7.1 to php71
|
|
if (file_exists($brewPrefix."/opt/{$oldPhpFormulaName}/bin/php")) {
|
|
return $brewPrefix."/opt/{$oldPhpFormulaName}/bin/php";
|
|
}
|
|
|
|
throw new Exception('Cannot find an executable path for provided PHP version: '.$phpFormulaName);
|
|
}
|
|
|
|
function presumePhpVersionFromBrewFormulaName(string $formulaName)
|
|
{
|
|
if ($formulaName === 'php') {
|
|
// Figure out its link
|
|
$details = json_decode(shell_exec("brew info $formulaName --json"));
|
|
|
|
if (! empty($details[0]->aliases[0])) {
|
|
$formulaName = $details[0]->aliases[0];
|
|
} else {
|
|
return null;
|
|
}
|
|
}
|
|
|
|
if (strpos($formulaName, 'php@') === false) {
|
|
return null;
|
|
}
|
|
|
|
return substr($formulaName, strpos($formulaName, '@') + 1);
|
|
}
|