phpmon/laravel-valet
1
0
Fork 0
mirror of https://github.com/laravel/valet.git synced 2026-02-04 16:10:08 +01:00
Code Activity

Add type hints and return types to ngrok

Browse Source
This commit is contained in:
Matt Stauffer
2022-12-19 19:17:30 -05:00
parent a6840040be
commit 7698611a6a
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
cli/Valet/Ngrok.php
View File

@@ -16,9 +16,10 @@ class Ngrok
/**
* Get the current tunnel URL from the Ngrok API.
*
* @param string|null $domain
* @return string
*/
public function currentTunnelUrl($domain = null)
public function currentTunnelUrl(?string $domain = null): string
{
// wait a second for ngrok to start before attempting to find available tunnels
sleep(1);
@@ -52,9 +53,10 @@ public function currentTunnelUrl($domain = null)
* Find the HTTP tunnel URL from the list of tunnels.
*
* @param array $tunnels
* @param string $domain
* @return string|null
*/
public function findHttpTunnelUrl($tunnels, $domain)
public function findHttpTunnelUrl(array $tunnels, string $domain): ?string
{
// If there are active tunnels on the Ngrok instance we will spin through them and
// find the one responding on HTTP. Each tunnel has an HTTP and a HTTPS address