phpmon/app
1
0
Fork 0
mirror of https://github.com/nicoverbruggen/phpmon.git synced 2025-08-07 03:50:08 +02:00
Code Releases Activity

✨ Tell users about older unsupported PHP versions

Browse Source
This commit is contained in:
Nico Verbruggen
2023-01-13 19:46:25 +01:00
parent 8d42e27ef6
commit 7c3f416789
3 changed files with 39 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
phpmon/Domain/Menu/MainMenu.swift
View File

@ -109,6 +109,24 @@ class MainMenu: NSObject, NSWindowDelegate, NSMenuDelegate, PhpSwitcherDelegate
}
}
@objc func showIncompatiblePhpVersionsAlert() {
Task { @MainActor in
BetterAlert().withInformation(
title: "startup.unsupported_versions_explanation.title".localized,
subtitle: "startup.unsupported_versions_explanation.subtitle".localized(
PhpEnv.shared.incompatiblePhpVersions
.map({ version in
return "• PHP \(version)"
})
.joined(separator: "\n")
),
description: "startup.unsupported_versions_explanation.desc".localized
)
.withPrimary(text: "generic.ok".localized)
.show()
}
}
/** Reloads the menu in the background, using `asyncExecution`. */
@objc func reloadPhpMonitorMenuInBackground() {
asyncExecution({

13
phpmon/Domain/Menu/StatusMenu+Items.swift
View File

@ -41,7 +41,7 @@ extension StatusMenu {
return
}
if PhpEnv.shared.availablePhpVersions.isEmpty {
if PhpEnv.shared.availablePhpVersions.isEmpty && PhpEnv.shared.incompatiblePhpVersions.isEmpty {
return
}
@ -67,7 +67,6 @@ extension StatusMenu {
func addSwitchToPhpMenuItems() {
var shortcutKey = 1
for index in (0..<PhpEnv.shared.availablePhpVersions.count).reversed() {
// Get the short and long version
let shortVersion = PhpEnv.shared.availablePhpVersions[index]
let longVersion = PhpEnv.shared.cachedPhpInstallations[shortVersion]!.versionNumber
@ -90,6 +89,16 @@ extension StatusMenu {
addItem(menuItem)
}
if !PhpEnv.shared.incompatiblePhpVersions.isEmpty {
addItem(NSMenuItem.separator())
addItem(NSMenuItem(
title: "⚠️ " + "mi_php_unsupported".localized(
"\(PhpEnv.shared.incompatiblePhpVersions.count)"
),
action: #selector(MainMenu.showIncompatiblePhpVersionsAlert)
))
}
}
func addCoreMenuItems() {

11
phpmon/Localizable.strings
View File

@ -12,6 +12,7 @@
"mi_unsure" = "We are not sure what version of PHP you are running.";
"mi_php_version" = "Global PHP version: PHP";
"mi_php_switch" = "Switch to PHP";
"mi_php_unsupported" = "Some installed PHP versions are not displayed.";
"mi_php_broken_1" = "Oof! It appears your PHP installation is broken...";
"mi_php_broken_2" = "Try running `php -v` in your terminal.";
"mi_php_broken_3" = "You could also try switching to another version.";
@ -563,8 +564,16 @@ If you are seeing this message but are confused why this folder has gone missing
"startup.version_mismatch.button_switch_back" = "Switch back to PHP %@";
"startup.version_mismatch.button_stay" = "Keep using PHP %@";
// SPONSOR ENCOURAGEMENT
// Warning about unsupported PHP versions
"startup.unsupported_versions_explanation.title" = "One or more PHP installed versions are not supported.";
"startup.unsupported_versions_explanation.subtitle" = "The following versions of PHP are installed on your system but are not supported by this version of Valet.
%@
Valet might break if you link these PHP versions so PHP Monitor won't let you switch to them.";
"startup.unsupported_versions_explanation.desc" = "If you need support for older versions of PHP, you may need to downgrade to an older versions of Valet. Otherwise, it might be a good idea to uninstall any outdated versions that are not in use.";
// Sponsor encouragement
"startup.sponsor_encouragement.title" = "If PHP Monitor has been useful to you or your company, please consider leaving a tip.";
"startup.sponsor_encouragement.subtitle" = "To be 100% transparent: I plan to keep PHP Monitor open source and free. Your support makes this decision very easy.\n\n(You will only see this prompt once.)";
"startup.sponsor_encouragement.desc" = "If you have already donated, then YOU are the reason why the app was able to get all these updates. In that case, this is a THANK YOU message to you. I appreciate the support.";