The domain-name determination using strrpos wasn't very efficient. Stripping the `.crt` from the end of the filename is easier to parse.
Now all it returns is the first part of the string up until the final `.`, treating the remainder as whatever tld was used for the domain, regardless of what tld valet is configured for.
> valet install
Stopping nginx...
Installing nginx configuration...
Installing nginx directory...
Installing php71...
Error: homebrew/dupes was deprecated. This tap is now empty as all its formulae were migrated.
Error: homebrew/versions was deprecated. This tap is now empty as all its formulae were migrated.
Error: homebrew/php was deprecated. This tap is now empty as all its formulae were migrated.
* Revert "wip"
This reverts commit 15c961e41e.
* Revert "fix changes where brew php paths now include @ and semver-style versions in paths (#545)"
This reverts commit 7f61475feb.
Update supportedPhpVersions to include the new names used by homebrew now that the php packages have migrated to 'core'. php71 has become php@7.1 etc
The new names are put at the front of the list to optimise the loops that use these collections.
Anyone who installs or updates 'homebrew php' from will start using the new packages names which breaks parts of valet.
The `substr` of `-8` was based on `.dev.crt`, but since the TLD has always been configurable, this should have always been dynamic.
Running `valet links` will not show `https` or the `TLS` columns correctly if the substring matching is of the wrong length.
Fixes#144
".test" or ".dev" is really a TLD, not a "domain" in the conventional sense.
Changing the command to `valet tld` more accurately reflects the purpose of the command (to set or get the configured TLD served by Valet)
The use of `valet domain` is currently preserved as an alias for `valet tld`, but will be removed at a later date.
Fixes#144
".dev" is really a TLD, not a "domain" in the conventional sense.
Changing the command to `valet tld` more accurately reflects the purpose of the command (to set or get the configured TLD served by Valet)
