Fixes#1407
Homebrew's support policy now aggressively disables older versions earlier than it did previously.
That is why we tap the `shivammathur/php` repository.
But since Homebrew also now "keeps" those old formulae but marks them as disabled, when Valet runs `brew install php@7.4` it fails because Homebrew just aborts due to its flags in the outdated formula.
(They mark it as "disabled" and/or "keg_only :versioned_formula", but don't actually delete the formula from their repository.)
To override that we must use `brew install shivammathur/php/php@7.4` internally.
Therefore, we need to maintain a list of which PHP Versions we wish to specifically prefix with the `shivammathur/php` tap in order to bypass Homebrew's flags.
**ANNUAL MAINTENANCE**
1. This PR adds the array of `LIMITED_PHP_VERSIONS` which we will have to update annually when new PHP versions are retired as others are released.
2. We should also annually update the `LATEST_PHP_VERSION` string.
* Extract basic driver with public/ from basic driver, and simplify both
* Apply fixes from StyleCI
* Set HTTP_HOST in BaseDriverTest
* Move server helpers to their own file; add type hints
* Update drivers location and loading
- Extract much of server.php into a `Server` class
- Move all but the Laravel and Basic drivers into a subfolder
- Load all but the Laravel and Basic drivers via glob
- Add `beforeLoading` hook to simplify the `frontControllerPath` method for some drivers
* Apply fixes from StyleCI
* Add additional notes to upgrade.md
* Apply fixes from StyleCI
* Require PHP 8.0
* Add type hints and return type hints to Brew
* Apply fixes from StyleCI
* Add type hints and return type hints to CommandLine
* Add type hints and return type hints to Configuration
* Add type hints and return type hints to Diagnose
* Apply fixes from StyleCI
* Add type hints and return type hints to DnsMasq
* Add type hints and return hints to Filesystem
* Add type hints and return types to Nginx
* Add type hints and return types to ngrok
* Add type hints and return types to PhpFpm
* Apply fixes from StyleCI
* Add type hints and return types to Site and Valet
* Apply fixes from StyleCI
* Require passing a version number to isolate command
* Apply fixes from StyleCI
* Bump compat to php 8; add type hints and return types to helpers
* Apply fixes from StyleCI
* Use constructor promotion
* Apply fixes from StyleCI
* Write tests for Server.php
* Apply fixes from StyleCI
* Move upgrade calls into Upgrader class, and add upgrade to check for old custom drivers
* Apply fixes from StyleCI
* Replace some \n with PHP_EOL; move custom drivers into Custom namespace
* Apply fixes from StyleCI
* Add doc blocks
* Clean up NullWriter; drop legacy config check
* Allow null response from frontControllerPath
* Apply fixes from StyleCI
* Drop exits, fix 404 path
* Better handle new installations
* Apply fixes from StyleCI
* Drop extensions
* Clean up DX for fetch-share-url
* Apply fixes from StyleCI
* Fix site::unlink method signature and docblock
* Tweak the wording for the which command
* Support isolated sites running PHP 7.4
* Add a bunch more CLI command tests (#1332)
* Wip some cli tests
* Apply fixes from StyleCI
* Test parked command
* Test forget command
* Update Filesystem::rmDirAndContents to respect symlinks
* Wip cli commands
* Apply fixes from StyleCI
* Test link command, unlink command, and secure command
* Apply fixes from StyleCI
* Add tests for unsecure, unsecure --all, secured commands
Add placeholders for the remaining CLI commands
Add nginx::restart to unsecure --all command
Co-authored-by: StyleCI Bot <bot@styleci.io>
* Drop old config migrations
* Add status command (#1329)
* Build the foundation of a status command
* Apply fixes from StyleCI
* Wip testing status command
* Apply fixes from StyleCI
* Fix status test
* Apply fixes from StyleCI
* Fix race condition in creating test config file
* Apply fixes from StyleCI
* Reset container for each test
* Differentiate response code based on success or failure of status command
* Apply fixes from StyleCI
* Add the ability to test if a Brew service is running
* Apply fixes from StyleCI
* Check for more services running in status command
* Apply fixes from StyleCI
* Test Status
* Apply fixes from StyleCI
* Drop Yoast from base application test case
Co-authored-by: StyleCI Bot <bot@styleci.io>
* Test most of the remaining CLI commands
* Test set tld command
* Test set loopback command
* Test proxy, unproxy, and proxies commands
* Apply fixes from StyleCI
* Test which command
* Test diagnose command
* Test directory-listing and which-php commands
* Text isolate and unisolate and isolated commands
* Apply fixes from StyleCI
* Test trust command
* Apply fixes from StyleCI
* Test on-latest-version command
* Move uninstall text to a class, and tweak text and presentation
* Apply fixes from StyleCI
* Test use command
* Test stop command
* Test start command
* Test restart command
Co-authored-by: StyleCI Bot <bot@styleci.io>
* Drop unnecessary doc blocks (#1339)
* Drop unnecessary doc blocks
* Apply fixes from StyleCI
Co-authored-by: StyleCI Bot <bot@styleci.io>
* Tweak status output and install output
* Add debug instructions to valet status, expand "valet installed" status check
* Drop extensions directory
* Apply fixes from StyleCI
* Remove more docblocks
* Upgrade ngrok to 3.1.0
* Test force uninstall command
* Test log command
* Drop copying Ngrok share to clipboard; add first steps of Expose code
* Add logic paths for Expose vs. ngrok and the share-tool config
* Apply fixes from StyleCI
* Take the first steps of manually installing ngrok and expose when needed
* Apply fixes from StyleCI
* Next steps Brew-installed ngrok
* Apply fixes from StyleCI
* Add class to represent Composer; continue ngrok + expose updates
* Apply fixes from StyleCI
* Add ensureInstalled() method to Expose and installOrFail() to Composer
* Apply fixes from StyleCI
* Require global PHP 8+ to install
* Exit if invalid domain is passed to valet share
* Update Composer dependencies to use Illuminate/Container
* Drop the idea of passing a custom domain to valet share
Co-authored-by: StyleCI Bot <bot@styleci.io>
* First attempt at testing CLI commands
* Apply fixes from StyleCI
* Protect from running locally
* Fix test
* wip
* wip
* wip
* wip
* wip
* Update app.php
* Create config folder and files for CLI tests
* Apply fixes from StyleCI
* Fix some formatting
* Fix imports
* Update all output() calls to use the writer passed in by the command
Ugly capture of all $outputs from commands, by passing them into `writer()` to be bound into the container, where they can then be pulled out from calls to `output()` and its buddies `info()`, `table()`, and `warning()`.
* Apply fixes from StyleCI
* Flesh out park command test
* Apply fixes from StyleCI
* Drop php 7.0 and 7.1
Co-authored-by: StyleCI Bot <bot@styleci.io>
Co-authored-by: Matt Stauffer <matt@tighten.co>
As discussed in #1220, cleaning up after stopping Homebrew services that
run as root is probably the best solution for now.
What's changed:
- Stopping any Homebrew service now restores the appropriate permissions
for the Homebrew directories
- Stopping nginx now also happens via $this->brew
(to avoid code duplication)
The tests were updated to reflect this change.
Before the change, when running `valet use` the code intended to stop currently running PHP services. But the `getRunningServices` method only returned non-root running services. As PHP services started by Valet are run using `sudo` (so running as root), they were not returned and subsequently not stopped.
This change is intended to fix the above and stop PHP services that are started by Valet on a PHP version switch.
This is intended to assist with avoiding having competing non-root instances of valet dependency services running due to userland use of brew CLI commands.
Now, when running `valet stop` or `valet restart` it will (silently) attempt to stop the non-root instance (ignoring any errors thrown), before stopping (and/or starting) the sudo/root instance which is normally used.
(Though obvious, I'll point out that this only applies to services Valet manages.)
Fixes#1057
Update test suite to phpunit 9.5 syntax
Refactored to use polyfill for older PHP versions via `yoast/phpunit-polyfills`
Note: this includes 2 important differences from usual phpunit test suites:
- instead of extending `PHPUnit\Framework\TestCase` we extend `Yoast\PHPUnitPolyfills\TestCases\TestCase`
- instead of handling fixtures via `setUp()` and `tearDown()` we use `set_up()` and `tear_down()` respectively
Comment regarding formatting: I chose to use the FQDN in the `extends` syntax of the class declaration instead of using `use` so that it is more quickly apparent that we're doing something slightly different than usual phpunit syntax, particularly in regards to the set_up() / tear_down() methods that appear immediately following the `extends` line.
