phpmon/laravel-valet
1
0
Fork 0
mirror of https://github.com/laravel/valet.git synced 2026-02-05 16:40:05 +01:00
Code Activity

Merge pull request #1460 from rana01645/master

Browse Source 
Update "fetch-share-url" to pull correct URL for HTTPS tunnels, not just HTTP
This commit is contained in:
Matt Stauffer
2023-12-20 22:39:06 -05:00
committed by GitHub
parent 3f2b62954c cd099f650f
commit 9c922e5a2f
2 changed files with 24 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
tests/NgrokTest.php
View File

@@ -47,10 +47,18 @@ public function test_it_matches_correct_share_tunnel()
],
'public_url' => 'http://right-one.ngrok.io/',
],
(object) [
'proto' => 'https',
'config' => (object) [
'addr' => 'http://mysecuresite.test:80',
],
'public_url' => 'http://secure-right-one.ngrok.io/',
],
];
$ngrok = resolve(Ngrok::class);
$this->assertEquals('http://right-one.ngrok.io/', $ngrok->findHttpTunnelUrl($tunnels, 'mysite'));
$this->assertEquals('http://secure-right-one.ngrok.io/', $ngrok->findHttpTunnelUrl($tunnels, 'mysecuresite'));
}
public function test_it_checks_against_lowercased_domain()