phpmon/laravel-valet
1
0
Fork 0
mirror of https://github.com/laravel/valet.git synced 2026-02-05 16:40:05 +01:00
Code Activity

Merge pull request #766 from Padrio/master

Browse Source 
Fixed warning on newer symfony/process versions
This commit is contained in:
Matt Stauffer
2019-04-11 15:43:00 -04:00
committed by GitHub
parent 911031fc82 6182e0c8b5
commit 9705801971
1 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
cli/Valet/CommandLine.php
View File

@@ -74,7 +74,14 @@ function runCommand($command, callable $onError = null)
{ {
$onError = $onError ?: function () {}; $onError = $onError ?: function () {};
// Symfony 4.x throws a warning when the command string is passed to the constructor
// But the version constraint allows older versions, too
// For more information, see: https://github.com/laravel/valet/pull/761
if (method_exists(Process::class, 'fromShellCommandline')) {
$process = Process::fromShellCommandline($command);
} else {
$process = new Process($command); $process = new Process($command);
}
$processOutput = ''; $processOutput = '';
$process->setTimeout(null)->run(function ($type, $line) use (&$processOutput) { $process->setTimeout(null)->run(function ($type, $line) use (&$processOutput) {