1
0
mirror of https://github.com/laravel/valet.git synced 2026-02-05 00:20:08 +01:00

Apply suggestions from code review

Co-authored-by: Matt Stauffer <mattstauffer@users.noreply.github.com>
This commit is contained in:
Nasir Uddin Nobin
2022-03-29 08:56:01 +06:00
committed by GitHub
parent 9a9f73faf9
commit 40cb21ec91
3 changed files with 17 additions and 16 deletions

View File

@@ -452,12 +452,12 @@ public function test_it_can_get_php_binary_path_from_php_version()
public function test_it_can_compare_two_php_versions()
{
$this->assertTrue(resolve(Brew::class)->isPhpVersionsEqual('php71', 'php@7.1'));
$this->assertTrue(resolve(Brew::class)->isPhpVersionsEqual('php71', 'php@71'));
$this->assertTrue(resolve(Brew::class)->isPhpVersionsEqual('php71', '71'));
$this->assertTrue(resolve(Brew::class)->arePhpVersionsEqual('php71', 'php@7.1'));
$this->assertTrue(resolve(Brew::class)->arePhpVersionsEqual('php71', 'php@71'));
$this->assertTrue(resolve(Brew::class)->arePhpVersionsEqual('php71', '71'));
$this->assertFalse(resolve(Brew::class)->isPhpVersionsEqual('php71', 'php@70'));
$this->assertFalse(resolve(Brew::class)->isPhpVersionsEqual('php71', '72'));
$this->assertFalse(resolve(Brew::class)->arePhpVersionsEqual('php71', 'php@70'));
$this->assertFalse(resolve(Brew::class)->arePhpVersionsEqual('php71', '72'));
}
/**