1
0
mirror of https://github.com/laravel/valet.git synced 2026-02-06 08:40:09 +01:00

stop running php and search brew for php to verify can install it before trying the wrong formula, todos for tests

This commit is contained in:
James Barnard
2019-01-19 22:07:56 +00:00
committed by Matt Stauffer
parent 28748baa80
commit 25c4fab2b4
5 changed files with 58 additions and 12 deletions

View File

@@ -336,4 +336,10 @@ public function test_unlink_will_pass_formula_to_run_as_user()
swap(CommandLine::class, $cli);
$this->assertSame('Some output', resolve(Brew::class)->unlink('aformula'));
}
// TODO: search will pass to brew search
// TODO: search will pass into grep if passed
// TODO: search will throw if fails
// TODO: getRunningServices will return array of services currently started
// TODO: getRunningServices can pass grep to filter result
}

View File

@@ -36,7 +36,15 @@ public function test_fpm_is_configured_with_the_correct_user_group_and_port()
$this->assertContains("\nlisten = ".VALET_HOME_PATH."/valet.sock", $contents);
}
// TODO: useVersion
// TODO: useVersion if no php at start it will prefix
// TODO: useVersion will pass version to Brew::search and then check if it's supported
// TODO: - if not supported will through
// TODO: useVersion if already linked php will unlink it
// TODO: useVersion will ensure new version is installed
// TODO: useVersion will link found version (force)
// TODO: useVersion will call install at end
// TODO: stopRunning will get the running php services and stop them
}