mirror of
https://github.com/nicoverbruggen/phpmon.git
synced 2025-08-07 20:10:08 +02:00
🐛 Correctly parse RC PHP version (#132)
It'll be a while before a new release candidate is available, but this bug has now been resolved. A new `PhpVersionNumber.parse` method has been added which can throw. The `VersionExtractor` class is now capable of extracting version numbers from all strings now too, and isn't just used to determine the Valet version number. New tests have been added to handle these scenarios. This commit also removes the phpmon-cli component, which wasn't being updated or maintained (it was an experiment).
This commit is contained in:
@ -118,6 +118,14 @@ public struct PhpVersionNumber: Equatable {
|
||||
*/
|
||||
}
|
||||
|
||||
public static func parse(_ text: String) throws -> Self {
|
||||
guard let versionText = VersionExtractor.from(text) else {
|
||||
throw VersionParseError()
|
||||
}
|
||||
|
||||
return Self.make(from: versionText)!
|
||||
}
|
||||
|
||||
public static func make(from versionString: String, type: MatchType = .versionOnly) -> Self? {
|
||||
let regex = try! NSRegularExpression(pattern: type.rawValue, options: [])
|
||||
let match = regex.matches(in: versionString, options: [], range: NSMakeRange(0, versionString.count)).first
|
||||
|
Reference in New Issue
Block a user