phpmon/app
1
0
Fork 0
mirror of https://github.com/nicoverbruggen/phpmon.git synced 2025-08-08 12:29:54 +02:00
Code Releases Activity

🔧 Disable valet switching for next release (#34)

Browse Source
This commit is contained in:
Nico Verbruggen
2021-12-17 13:11:22 +01:00
parent 5c391917d2
commit eaf653e3c0
2 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
phpmon/Domain/Menu/MainMenu.swift
View File

@@ -376,6 +376,7 @@ class MainMenu: NSObject, NSWindowDelegate, NSMenuDelegate {
} }
} }
/* DISABLED UNTIL VALET SWITCHING IS OK (see #34)
if Preferences.preferences[.useInternalSwitcher] as! Bool == false { if Preferences.preferences[.useInternalSwitcher] as! Bool == false {
// 1. Default switcher using Valet // 1. Default switcher using Valet
// Will cause less issues, but is slower // Will cause less issues, but is slower
@@ -384,7 +385,7 @@ class MainMenu: NSObject, NSWindowDelegate, NSMenuDelegate {
availableVersions: App.shared.availablePhpVersions, availableVersions: App.shared.availablePhpVersions,
completed: completion completed: completion
) )
} else { } else { */
// 2. Custom switcher (internal) // 2. Custom switcher (internal)
// Will cause more issues with Homebrew and is faster // Will cause more issues with Homebrew and is faster
Actions.switchToPhpVersion( Actions.switchToPhpVersion(
@@ -392,7 +393,7 @@ class MainMenu: NSObject, NSWindowDelegate, NSMenuDelegate {
availableVersions: App.shared.availablePhpVersions, availableVersions: App.shared.availablePhpVersions,
completed: completion completed: completion
) )
} /* } */
} }
} }

3
phpmon/Domain/Preferences/PrefsVC.swift
View File

@@ -74,13 +74,14 @@ class PrefsVC: NSViewController {
preference: .autoServiceRestartAfterExtensionToggle, preference: .autoServiceRestartAfterExtensionToggle,
action: {} action: {}
), ),
/* DISABLED UNTIL VALET SWITCHING IS OK (see #34)
CheckboxPreferenceView.make( CheckboxPreferenceView.make(
sectionText: "", sectionText: "",
descriptionText: "prefs.use_internal_switcher_desc".localized, descriptionText: "prefs.use_internal_switcher_desc".localized,
checkboxText: "prefs.use_internal_switcher".localized, checkboxText: "prefs.use_internal_switcher".localized,
preference: .useInternalSwitcher, preference: .useInternalSwitcher,
action: {} action: {}
), ), */
HotkeyPreferenceView.make( HotkeyPreferenceView.make(
sectionText: "prefs.global_shortcut".localized, sectionText: "prefs.global_shortcut".localized,
descriptionText: "prefs.shortcut_desc".localized, descriptionText: "prefs.shortcut_desc".localized,