♻️ Refactor PhpSwitcher into PhpEnv

phpmon-common/PHP/ActivePhpInstallation+Checks.swift

@@ -1,33 +0,0 @@
-//
-//  ActivePhpInstallation.swift
-//  PHP Monitor
-//
-//  Created by Nico Verbruggen on 21/12/2021.
-//  Copyright © 2021 Nico Verbruggen. All rights reserved.
-//
-
-import Foundation
-
-extension ActivePhpInstallation {
-    
-    /**
-     It is always possible that the system configuration for PHP-FPM has not been set up for Valet.
-     This can occur when a user manually installs a new PHP version, but does not run `valet install`.
-     In that case, we should alert the user!
-     
-     - Important: The underlying check is `checkPhpFpmStatus`, which can be run multiple times.
-     This method actively presents a modal if said checks fails, so don't call this method too many times.
-     */
-    public func notifyAboutBrokenPhpFpm() {
-        if !self.checkPhpFpmStatus() {
-            DispatchQueue.main.async {
-                Alert.notify(
-                    message: "alert.php_fpm_broken.title".localized,
-                    info: "alert.php_fpm_broken.info".localized,
-                    style: .critical
-                )
-            }
-        }
-    }
-    
-}

phpmon-common/PHP/ActivePhpInstallation.swift

@@ -25,7 +25,7 @@ class ActivePhpInstallation {
     // MARK: - Computed
     
     var formula: String {
-        return (version.short == PhpSwitcher.brewPhpVersion) ? "php" : "php@\(version.short)"
+        return (version.short == PhpEnv.brewPhpVersion) ? "php" : "php@\(version.short)"
     }
     
     // MARK: - Initializer

phpmon-common/PHP/PhpEnv.swift

@@ -13,7 +13,7 @@ protocol PhpSwitcherDelegate: AnyObject {
     func switcherDidCompleteSwitch()
 }
 
-class PhpSwitcher {
+class PhpEnv {
     
     // MARK: - Initializer
     
@@ -36,7 +36,7 @@ class PhpSwitcher {
     weak var delegate: PhpSwitcherDelegate?
 
     /** The static app instance. Accessible at any time. */
-    static let shared = PhpSwitcher()
+    static let shared = PhpEnv()
     
     /** Whether the switcher is busy performing any actions. */
     var isBusy: Bool = false
@@ -77,6 +77,12 @@ class PhpSwitcher {
     
     // MARK: - Methods
     
+    public static var switcher: PhpSwitcher {
+        // Based on the setting, use a particular switcher
+        // For now, we'll hardcode the internal switcher though
+        return InternalSwitcher()
+    }
+    
     public static func detectPhpVersions() -> Void {
         _ = Self.shared.detectPhpVersions()
     }

phpmon-common/PHP/PhpExtension.swift

@@ -78,7 +78,7 @@ class PhpExtension {
             // ENABLED: Line where the comment delimiter (;) is removed
             : line.replacingOccurrences(of: "; ", with: "")
         
-        Actions.sed(file: file, original: line, replacement: newLine)
+        sed(file: file, original: line, replacement: newLine)
         
         enabled.toggle()
     }

phpmon-common/PHP/Switcher/InternalSwitcher.swift

@@ -0,0 +1,58 @@
+//
+//  InternalSwitcher.swift
+//  PHP Monitor
+//
+//  Created by Nico Verbruggen on 24/12/2021.
+//  Copyright © 2021 Nico Verbruggen. All rights reserved.
+//
+
+import Foundation
+
+class InternalSwitcher: PhpSwitcher {
+    
+    /**
+     Switching to a new PHP version involves:
+     - unlinking the current version
+     - stopping the active services
+     - linking the new desired version
+     
+     Please note that depending on which version is installed,
+     the version that is switched to may or may not be identical to `php`
+     (without @version).
+     */
+    func performSwitch(to version: String, completion: @escaping () -> Void)
+    {
+        Log.info("Switching to \(version), unlinking all versions...")
+        
+        let group = DispatchGroup()
+        
+        PhpEnv.shared.availablePhpVersions.forEach { (available) in
+            group.enter()
+            
+            DispatchQueue.global(qos: .userInitiated).async {
+                let formula = (available == PhpEnv.brewPhpVersion)
+                ? "php" : "php@\(available)"
+                
+                brew("unlink \(formula)")
+                brew("services stop \(formula)", sudo: true)
+                
+                Log.perf("Unlinked and stopped services for \(formula)")
+                
+                group.leave()
+            }
+        }
+        
+        group.notify(queue: .global(qos: .userInitiated)) {
+            Log.info("All versions have been unlinked!")
+            Log.info("Linking the new version!")
+            
+            let formula = (version == PhpEnv.brewPhpVersion) ? "php" : "php@\(version)"
+            brew("link \(formula) --overwrite --force")
+            brew("services start \(formula)", sudo: true)
+            
+            Log.info("The new version has been linked!")
+            completion()
+        }
+    }
+    
+}

phpmon-common/PHP/Switcher/PhpSwitcher.swift

@@ -0,0 +1,15 @@
+//
+//  PhpVersionSwitchContract.swift
+//  PHP Monitor
+//
+//  Created by Nico Verbruggen on 24/12/2021.
+//  Copyright © 2021 Nico Verbruggen. All rights reserved.
+//
+
+import Foundation
+
+protocol PhpSwitcher {
+    
+    func performSwitch(to version: String, completion: @escaping () -> Void)
+    
+}