phpmon/app
1
0
Fork 0
mirror of https://github.com/nicoverbruggen/phpmon.git synced 2026-04-03 01:50:09 +02:00
Code Issues Activity

📝 TODO items as warnings

Browse Source
This commit is contained in:
Nico Verbruggen
2023-11-21 22:37:28 +01:00
parent 1e4c45dcbd
commit 67a00f979a
2 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
phpmon/Domain/Integrations/Homebrew/Commands/RemovePhpExtensionCommand.swift
View File

@@ -52,6 +52,8 @@ class RemovePhpExtensionCommand: BrewCommand {
await MainMenu.shared.refreshActiveInstallation() await MainMenu.shared.refreshActiveInstallation()
#warning("Remaining config files should be cleaned up")
onProgress(.create(value: 1, title: getCommandTitle(), description: "phpman.steps.success".localized)) onProgress(.create(value: 1, title: getCommandTitle(), description: "phpman.steps.success".localized))
} else { } else {
throw BrewCommandError(error: "phpman.steps.failure".localized, log: loggedMessages) throw BrewCommandError(error: "phpman.steps.failure".localized, log: loggedMessages)

1
phpmon/Modules/PHP Extension Manager/UI/PhpExtensionManagerView.swift
View File

@@ -99,6 +99,7 @@ struct PhpExtensionManagerView: View {
HStack { HStack {
if bExtension.isInstalled { if bExtension.isInstalled {
Button("phpman.buttons.uninstall".localizedForSwiftUI, role: .destructive) { Button("phpman.buttons.uninstall".localizedForSwiftUI, role: .destructive) {
#warning("Removal should ask for confirmation")
Task { await self.runCommand( Task { await self.runCommand(
RemovePhpExtensionCommand(remove: bExtension) RemovePhpExtensionCommand(remove: bExtension)
) } ) }