phpmon/app
1
0
Fork 0
mirror of https://github.com/nicoverbruggen/phpmon.git synced 2025-12-21 03:10:06 +01:00
Code Issues Activity

✅ Document confirmed fix w/ Thread Sanitizer

Browse Source
This commit is contained in:
Nico Verbruggen
2025-11-29 11:30:40 +01:00
parent a4cbbd28cc
commit 3e1bd26b38
1 changed files with 19 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
tests/unit/Testables/Shell/RealShellTest.swift
View File

@@ -78,14 +78,28 @@ struct RealShellTest {
#expect(duration < .milliseconds(2000)) // Should complete in ~700ms if parallel #expect(duration < .milliseconds(2000)) // Should complete in ~700ms if parallel
} }
@Test func attach_handles_concurrent_stdout_stderr_writes_safely() async throws { /**
// This test verifies that concurrent writes to output.out and output.err This test verifies that concurrent writes to `output.out` and `output.err`
// from multiple readability handlers don't cause data races or crashes. from multiple readability handlers don't cause data races or crashes,
// Without the serial queue, rapid interleaved output causes undefined behavior. and that the output is correct (for both stdout and stderr output).
When Thread Sanitizer is enabled, this will also check if any potential
data races occur. None should, at this point. You can enable the
Thread Sanitizer by editing the Test Plan's Configurations.
This test was added specifically to diagnose and fix one such reported
data race, which was fixed by adding a serial queue to the shell's
`attach()` method, since the readability handlers actually run
on separate threads.
*/
@Test func attach_handles_concurrent_stdout_stderr_writes_safely() async throws {
// Create a PHP script that will output lots of text to STDOUT and STDERR.
let phpScript = "php -r 'for ($i = 1; $i <= 500; $i++) { fwrite(STDOUT, \"stdout-$i\" . PHP_EOL); fwrite(STDERR, \"stderr-$i\" . PHP_EOL); flush(); }'" let phpScript = "php -r 'for ($i = 1; $i <= 500; $i++) { fwrite(STDOUT, \"stdout-$i\" . PHP_EOL); fwrite(STDERR, \"stderr-$i\" . PHP_EOL); flush(); }'"
// Keep track of the total chunk count
var receivedChunks = 0 var receivedChunks = 0
// We will now test the attach method
let (_, shellOutput) = try await container.shell.attach( let (_, shellOutput) = try await container.shell.attach(
phpScript, phpScript,
didReceiveOutput: { _, _ in didReceiveOutput: { _, _ in
@@ -105,7 +119,7 @@ struct RealShellTest {
#expect(stdoutLines.count == 500) #expect(stdoutLines.count == 500)
#expect(stderrLines.count == 500) #expect(stderrLines.count == 500)
// Verify content integrity - each line should match the pattern // Verify content integrity
for i in 1...200 { for i in 1...200 {
#expect(stdoutLines.contains("stdout-\(i)")) #expect(stdoutLines.contains("stdout-\(i)"))
#expect(stderrLines.contains("stderr-\(i)")) #expect(stderrLines.contains("stderr-\(i)"))