From 0fa6d337f2239e6c640e1b173c48c1ab5030d3e9 Mon Sep 17 00:00:00 2001
From: Nico Verbruggen <mail@nicoverbruggen.be>
Date: Wed, 9 Feb 2022 22:53:37 +0100
Subject: [PATCH] =?UTF-8?q?=F0=9F=91=8C=20Wrote=20down=20some=20notes=20du?=
 =?UTF-8?q?ring=20Deep=20Dive?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 phpmon/Common/Core/Shell.swift               | 1 +
 phpmon/Domain/App/App.swift                  | 1 +
 phpmon/Domain/Integrations/Valet/Valet.swift | 2 +-
 3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/phpmon/Common/Core/Shell.swift b/phpmon/Common/Core/Shell.swift
index 8ea3e2e..49529f6 100644
--- a/phpmon/Common/Core/Shell.swift
+++ b/phpmon/Common/Core/Shell.swift
@@ -108,6 +108,7 @@ public class Shell {
      Checks if a file exists at a certain path.
      Used to be done with a shell command, now uses the native FileManager class instead.
      */
+    // TODO: To be moved
     public static func fileExists(_ path: String) -> Bool {
         let fullPath = path.replacingOccurrences(of: "~", with: "/Users/\(Paths.whoami)")
         return FileManager.default.fileExists(atPath: fullPath)
diff --git a/phpmon/Domain/App/App.swift b/phpmon/Domain/App/App.swift
index ae76d89..8e1edf3 100644
--- a/phpmon/Domain/App/App.swift
+++ b/phpmon/Domain/App/App.swift
@@ -23,6 +23,7 @@ class App {
     }
     
     /** Whether the app is busy doing something. Used to determine what UI to display. */
+    // TODO: Remove this, and always use PhpEnv.shared.isBusy
     static var busy: Bool {
         return PhpEnv.shared.isBusy
     }
diff --git a/phpmon/Domain/Integrations/Valet/Valet.swift b/phpmon/Domain/Integrations/Valet/Valet.swift
index 3ab6390..961d0df 100644
--- a/phpmon/Domain/Integrations/Valet/Valet.swift
+++ b/phpmon/Domain/Integrations/Valet/Valet.swift
@@ -24,7 +24,7 @@ class Valet {
     /// Whether we're busy with some blocking operation.
     var isBusy: Bool = false
     
-    /// When initialising the Valet singleton, extract the Valet version and assume no sites loaded.
+    /// When initialising the Valet singleton assume no sites loaded. We will load the version later.
     init() {
         self.version = nil
         self.sites = []