From 09a5cf836a2863f117a8bbfc8e94d7ac47cbce06 Mon Sep 17 00:00:00 2001 From: Nico Verbruggen Date: Tue, 15 Mar 2022 22:40:40 +0100 Subject: [PATCH] =?UTF-8?q?=F0=9F=93=9D=20Added=20TODO=20comments?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- phpmon/Common/PHP/Switcher/InternalSwitcher.swift | 3 +++ 1 file changed, 3 insertions(+) diff --git a/phpmon/Common/PHP/Switcher/InternalSwitcher.swift b/phpmon/Common/PHP/Switcher/InternalSwitcher.swift index 3ed7f46..bdd2e84 100644 --- a/phpmon/Common/PHP/Switcher/InternalSwitcher.swift +++ b/phpmon/Common/PHP/Switcher/InternalSwitcher.swift @@ -31,6 +31,7 @@ class InternalSwitcher: PhpSwitcher { } var versions: Set = [] + // TODO: Do not use isolation if on Valet 2.x versions = versions.union(isolated) versions = versions.union([version]) @@ -79,6 +80,8 @@ class InternalSwitcher: PhpSwitcher { } brew("services start \(formula)", sudo: true) + + // TODO: Symlink might not need to be created if Valet 2.x let socketVersion = version.replacingOccurrences(of: ".", with: "") Shell.run("ln -sF ~/.config/valet/valet\(socketVersion).sock ~/.config/valet/valet.sock") Log.perf("Symlinked new socket version.")