From 020a0260f1ebe09454a777c845159bed527e95a6 Mon Sep 17 00:00:00 2001
From: Nico Verbruggen <mail@nicoverbruggen.be>
Date: Fri, 13 Jan 2023 19:46:25 +0100
Subject: [PATCH] =?UTF-8?q?=E2=9C=A8=20Tell=20users=20about=20older=20unsu?=
 =?UTF-8?q?pported=20PHP=20versions?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 phpmon/Domain/Menu/MainMenu.swift         | 18 ++++++++++++++++++
 phpmon/Domain/Menu/StatusMenu+Items.swift | 13 +++++++++++--
 phpmon/Localizable.strings                | 11 ++++++++++-
 3 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/phpmon/Domain/Menu/MainMenu.swift b/phpmon/Domain/Menu/MainMenu.swift
index 0dc8fef..cfd8ae8 100644
--- a/phpmon/Domain/Menu/MainMenu.swift
+++ b/phpmon/Domain/Menu/MainMenu.swift
@@ -109,6 +109,24 @@ class MainMenu: NSObject, NSWindowDelegate, NSMenuDelegate, PhpSwitcherDelegate
         }
     }
 
+    @objc func showIncompatiblePhpVersionsAlert() {
+        Task { @MainActor in
+            BetterAlert().withInformation(
+                title: "startup.unsupported_versions_explanation.title".localized,
+                subtitle: "startup.unsupported_versions_explanation.subtitle".localized(
+                    PhpEnv.shared.incompatiblePhpVersions
+                        .map({ version in
+                            return "• PHP \(version)"
+                        })
+                        .joined(separator: "\n")
+                ),
+                description: "startup.unsupported_versions_explanation.desc".localized
+            )
+            .withPrimary(text: "generic.ok".localized)
+            .show()
+        }
+    }
+
     /** Reloads the menu in the background, using `asyncExecution`. */
     @objc func reloadPhpMonitorMenuInBackground() {
         asyncExecution({
diff --git a/phpmon/Domain/Menu/StatusMenu+Items.swift b/phpmon/Domain/Menu/StatusMenu+Items.swift
index 0d4c189..88147bc 100644
--- a/phpmon/Domain/Menu/StatusMenu+Items.swift
+++ b/phpmon/Domain/Menu/StatusMenu+Items.swift
@@ -30,7 +30,7 @@ extension StatusMenu {
             return
         }
 
-        if PhpEnv.shared.availablePhpVersions.isEmpty { return }
+        if PhpEnv.shared.availablePhpVersions.isEmpty && PhpEnv.shared.incompatiblePhpVersions.isEmpty { return }
 
         addSwitchToPhpMenuItems()
         self.addItem(NSMenuItem.separator())
@@ -50,7 +50,6 @@ extension StatusMenu {
     func addSwitchToPhpMenuItems() {
         var shortcutKey = 1
         for index in (0..<PhpEnv.shared.availablePhpVersions.count).reversed() {
-
             // Get the short and long version
             let shortVersion = PhpEnv.shared.availablePhpVersions[index]
             let longVersion = PhpEnv.shared.cachedPhpInstallations[shortVersion]!.versionNumber
@@ -72,6 +71,16 @@ extension StatusMenu {
 
             addItem(menuItem)
         }
+
+        if !PhpEnv.shared.incompatiblePhpVersions.isEmpty {
+            addItem(NSMenuItem.separator())
+            addItem(NSMenuItem(
+                title: "⚠️ " + "mi_php_unsupported".localized(
+                    "\(PhpEnv.shared.incompatiblePhpVersions.count)"
+                ),
+                action: #selector(MainMenu.showIncompatiblePhpVersionsAlert)
+            ))
+        }
     }
 
     func addCoreMenuItems() {
diff --git a/phpmon/Localizable.strings b/phpmon/Localizable.strings
index e84842e..50ded14 100644
--- a/phpmon/Localizable.strings
+++ b/phpmon/Localizable.strings
@@ -12,6 +12,7 @@
 "mi_unsure" = "We are not sure what version of PHP you are running.";
 "mi_php_version" = "Global PHP version: PHP";
 "mi_php_switch" = "Switch to PHP";
+"mi_php_unsupported" = "Some installed PHP versions are not displayed.";
 "mi_php_broken_1" = "Oof! It appears your PHP installation is broken...";
 "mi_php_broken_2" = "Try running `php -v` in your terminal.";
 "mi_php_broken_3" = "You could also try switching to another version.";
@@ -560,8 +561,16 @@ If you are seeing this message but are confused why this folder has gone missing
 "startup.version_mismatch.button_switch_back" = "Switch back to PHP %@";
 "startup.version_mismatch.button_stay" = "Keep using PHP %@";
 
-// SPONSOR ENCOURAGEMENT
+// Warning about unsupported PHP versions
+"startup.unsupported_versions_explanation.title" = "One or more PHP installed versions are not supported.";
+"startup.unsupported_versions_explanation.subtitle" = "The following versions of PHP are installed on your system but are not supported by this version of Valet.
 
+%@
+
+Valet might break if you link these PHP versions so PHP Monitor won't let you switch to them.";
+"startup.unsupported_versions_explanation.desc" = "If you need support for older versions of PHP, you may need to downgrade to an older versions of Valet. Otherwise, it might be a good idea to uninstall any outdated versions that are not in use.";
+
+// Sponsor encouragement
 "startup.sponsor_encouragement.title" = "If PHP Monitor has been useful to you or your company, please consider leaving a tip.";
 "startup.sponsor_encouragement.subtitle" = "To be 100% transparent: I plan to keep PHP Monitor open source and free. Your support makes this decision very easy.\n\n(You will only see this prompt once.)";
 "startup.sponsor_encouragement.desc" = "If you have already donated, then YOU are the reason why the app was able to get all these updates. In that case, this is a THANK YOU message to you. I appreciate the support.";