nico/kobopatch-webui
1
0
Fork 0
Code Activity

Added connect instructions to improve UX

Browse Source
This commit is contained in:
Nico Verbruggen
2026-03-23 20:12:17 +01:00
parent 7eb99913bc
commit a6dbc17840
6 changed files with 100 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/e2e/helpers/mock-device.js
View File

@@ -151,6 +151,8 @@ async function connectMockDevice(page, opts = {}) {
await overrideFirmwareURLs(page);
}
await page.click('#btn-connect');
await expect(page.locator('#step-connect-instructions')).not.toBeHidden();
await page.click('#btn-connect-ready');
await expect(page.locator('#step-device')).not.toBeHidden();
await expect(page.locator('#device-model')).toHaveText('Kobo Libra Colour');
await expect(page.locator('#device-firmware')).toHaveText('4.45.23646');

16
tests/e2e/integration.spec.js
View File

@@ -743,6 +743,8 @@ test.describe('Custom patches', () => {
await page.goto('/');
await injectMockDevice(page, { firmware: '5.0.0' });
await page.click('#btn-connect');
await expect(page.locator('#step-connect-instructions')).not.toBeHidden();
await page.click('#btn-connect-ready');
// Device info should be displayed
await expect(page.locator('#step-device')).not.toBeHidden();
@@ -763,6 +765,8 @@ test.describe('Custom patches', () => {
await page.goto('/');
await injectMockDevice(page, { serial: 'X9990A0000000' });
await page.click('#btn-connect');
await expect(page.locator('#step-connect-instructions')).not.toBeHidden();
await page.click('#btn-connect-ready');
// Device info should be displayed with unknown model
await expect(page.locator('#step-device')).not.toBeHidden();
@@ -1002,6 +1006,18 @@ test.describe('Custom patches', () => {
await injectMockDevice(page);
await page.click('#btn-connect');
// Step 1a: Connection instructions
await expect(page.locator('#step-connect-instructions')).not.toBeHidden();
// Back from instructions returns to connect step
await page.click('#btn-connect-instructions-back');
await expect(page.locator('#step-connect')).not.toBeHidden();
// Forward again through instructions
await page.click('#btn-connect');
await expect(page.locator('#step-connect-instructions')).not.toBeHidden();
await page.click('#btn-connect-ready');
// Step 1: Device
await expect(page.locator('#step-device')).not.toBeHidden();