nico/NickelMenu-custom
1
0
Fork 0
Code Releases 1 Activity

Add 21533-23552 to symbol tests

Browse Source
This commit is contained in:
Patrick Gaskin
2025-12-06 19:34:32 -05:00
parent bfb872a0b9
commit c75dca48e5
4 changed files with 46 additions and 29 deletions
Download Patch File Download Diff File Expand all files Collapse all files

32
test/syms/main.go
View File

@@ -6,10 +6,11 @@ import (
"bytes"
"fmt"
"io"
"io/ioutil"
"maps"
"net/http"
"os"
"path/filepath"
"slices"
"sort"
"strconv"
"strings"
@@ -37,7 +38,10 @@ func main() {
"4.25.15875", "4.26.16704", "4.28.17623", "4.28.17820", "4.28.17826",
"4.28.17925", "4.28.18220", "4.29.18730", "4.30.18838", "4.31.19086",
"4.32.19501", "4.33.19608", "4.33.19611", "4.33.19759", "4.34.20097",
"4.35.20400", "4.36.21095",
"4.35.20400", "4.36.21095", "4.37.21533", "4.37.21582", "4.37.21586",
"4.38.21908", "4.39.22801", "4.39.22861", "4.38.23038", "4.39.23027",
"4.40.23081", "4.41.23145", "4.38.23171", "4.42.23296", "4.38.23429",
"4.43.23418", "4.38.23552", "4.44.23552",
}
checks := map[string]map[string][]SymCheck{}
@@ -65,13 +69,8 @@ func main() {
}
}
var checkVersions []string
for version := range checks {
checkVersions = append(checkVersions, version)
}
sort.Slice(checkVersions, func(i, j int) bool {
return versioncmp(checkVersions[i], checkVersions[j]) == -1
})
checkVersions := slices.SortedFunc(maps.Keys(checks), versioncmp)
fmt.Printf("[INF] sorted versions: %s\n", checkVersions)
var errs []error
gherrs := map[string][]string{}
@@ -179,7 +178,7 @@ func GetPatcher(version, lib string) (*patchlib.Patcher, error) {
}
}
buf, err := ioutil.ReadAll(tr)
buf, err := io.ReadAll(tr)
if err != nil {
return nil, fmt.Errorf("read kobopatch testdata: %w", err)
}
@@ -252,6 +251,19 @@ func versioncmp(a, b string) int {
return 0
}
aspl, bspl := splint(a), splint(b)
if false { // I think it might be less confusing to just explicitly list both if required, as they are branches and not all changes are in each
if len(aspl) == 3 && len(bspl) == 3 && aspl[0] == 4 && bspl[0] == 4 && aspl[1] >= 38 && bspl[1] >= 38 {
// if 4.38/4.39+ branching, sort by only the build number
switch {
case aspl[2] < bspl[2]:
return -1
case aspl[2] > bspl[2]:
return 1
case aspl[2] == bspl[2] && aspl[1] == bspl[1]: // fall back to normal compare if not entirely equal
return 0
}
}
}
mlen := len(aspl)
if len(bspl) > mlen {
mlen = len(bspl)